Closed bradenmacdonald closed 1 year ago
Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
f247cfc
) 97.74% compared to head (9abedc9
) 97.75%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@bradenmacdonald, it's unrelated to this PR, but I noticed a race condition when there are multiple LTI Consumer XBlocks in a single unit. The first block has a correct LTI ID, and the second one has an incorrect one. I didn't change anything between these screenshots - I only refreshed the page.
Should we open a new issue?
@Agrendalath Thanks for the review! I see you're a CC here, so is this good to merge now?
Should we open a new issue?
Looks like we should to me, yep. Thanks for noticing that.
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
This adds a new warning in Studio for LTI 1.1/1.2 consumer components if the specified
lti_id
is not valid for the current course. It doesn't block you from setting an invalid ID, in case you're setting the ID first in the XBlock, then later in Advanced Settings.Private-ref: MNG-3638