Closed ilee2u closed 1 year ago
Patch coverage: 100.00%
and project coverage change: +0.13%
:tada:
Comparison is base (
b57ccbb
) 97.76% compared to head (0c3fdb9
) 97.89%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Seeing now that codecov fails, but if I recall correctly, it isn't really feasible to run unit tests on some of these error messages due to how dependent on the LTI dataflow each piece of this is.
@ilee2u took a look at the missing cases and I think it should be relatively straightforward to add some tests. We can add on to https://github.com/openedx/xblock-lti-consumer/blob/c659e07aa743cb89d8f04a41673ec58e85c9f7fe/lti_consumer/tests/unit/test_lti_xblock.py#L834 that mocks extract_real_user_data
throwing and error and it looks like we already have error tests for the other missing cases in TestLti1p3LaunchGateEndpoint we just need an invalid context claim launch and another test that mocks out validate_lti_1p3_launch_data
. Lemme know if you need help on setting these up
Ticket: MST-1931