search

openedx / xblock-lti-consumer

GNU Affero General Public License v3.0
28 stars 80 forks source link

Previously supported custom parameters not passing validation #410

Open alangsto opened 12 months ago

alangsto commented 12 months ago

https://github.com/openedx/xblock-lti-consumer/pull/392 introduced a breaking change that prevents previously allowed custom parameters from passing validation.

Example of custom parameter that now does not pass validation:

["next=something?repo=https://github.com/org/repo?folder=/home/user&branch=main"]

Changes to the custom parameter validation should be backwards compatible, and account for cases like this where the user passes in a single string.

alangsto commented 12 months ago

@kuipumu tagging you as the author of https://github.com/openedx/xblock-lti-consumer/pull/392.

kuipumu commented 11 months ago

@alangsto I created a PR that should address this issue https://github.com/openedx/xblock-lti-consumer/pull/412, this should be loose enough to allow any kind on key-pair value has a custom parameter.