Closed kuipumu closed 9 months ago
Thanks for the pull request, @kuipumu! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
07a8c26
) 97.84% compared to head (dbc0590
) 97.84%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@kuipumu would you mind updating the version in https://github.com/openedx/xblock-lti-consumer/blob/master/lti_consumer/__init__.py? Thank you!
@alangsto Sure, just added a commit with an update to init and CHANGELOG.rst
Hi @alangsto! Are you able to merge this if it's good-to-go?
@kuipumu Hi there! Would you mind resolving the branch conflicts that have popped up?
@alangsto - is this something you can merge for us? Thanks!
@mphilbrick211 I resolved the conflicts and updated the version and changelog.
Thanks, @kuipumu! @alangsto this look ready for merge. Thanks!
@kuipumu 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Description
This PR adds a fix to the validation of the LTI consumer XBlock custom parameters field. The previously merged PR https://github.com/openedx/xblock-lti-consumer/pull/392 introduced a bug that broke backwards compatible with custom parameters such has:
["next=something?repo=https://github.com/org/repo?folder=/home/user&branch=main"]
. This issue was raised on https://github.com/openedx/xblock-lti-consumer/issues/410.Type of Change
Testing: