Closed kuipumu closed 5 months ago
Thanks for the pull request, @kuipumu! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
f36725a
) 97.95% compared to head (291567b
) 97.93%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @kuipumu! Would you mind rebasing this pull request? Doing so might help resolve the codecov errors. If that doesn't work, I'll look into it for you. Thanks!
Hi @kuipumu! Would you mind rebasing this pull request? Doing so might help resolve the codecov errors. If that doesn't work, I'll look into it for you. Thanks!
Hi @kiram15! Friendly follow-up on this!
Hi @kuipumu! Just checking in to see if you plan to pursue this pull request?
Hi @kuipumu! I'm going to close this pull request for now, but we can reopen in the future if you'd like to pursue. Thanks!
@kuipumu Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.
Description
This PR adds a fix for the LTI external configurations feature issue https://github.com/openedx/xblock-lti-consumer/issues/420
Type of Change
_get_lti_config_for_block
function onplugin/api.py
module to raise anExternalConfigurationNotFound
error when no external LTI configuration is found.Testing