openedx / xblock-lti-consumer

GNU Affero General Public License v3.0
28 stars 80 forks source link

fix: Missing external configuration error message #423

Closed kuipumu closed 5 months ago

kuipumu commented 10 months ago

Description

This PR adds a fix for the LTI external configurations feature issue https://github.com/openedx/xblock-lti-consumer/issues/420

Type of Change

Testing

  1. Create a course and add a LTI consumer XBlock.
  2. Edit the XBlock settings and set "Configuration Type" to "Reusable Configuration".
  3. Edit the XBlock settings and set "LTI Reusable Configuration ID" to an nonexistent external configuration (Ex: test:test).
  4. Save the XBlock and reload the studio editor.
  5. The studio view should show an exception.
  6. Go to the learning MFE and load the unit where the XBlock is.
  7. The learning MFE should show an general unexpected exception.
openedx-webhooks commented 10 months ago

Thanks for the pull request, @kuipumu! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f36725a) 97.95% compared to head (291567b) 97.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #423 +/- ## ========================================== - Coverage 97.95% 97.93% -0.02% ========================================== Files 77 77 Lines 6686 6689 +3 ========================================== + Hits 6549 6551 +2 - Misses 137 138 +1 ``` | [Flag](https://app.codecov.io/gh/openedx/xblock-lti-consumer/pull/423/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openedx/xblock-lti-consumer/pull/423/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | `97.93% <75.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/openedx/xblock-lti-consumer/pull/423?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [lti\_consumer/api.py](https://app.codecov.io/gh/openedx/xblock-lti-consumer/pull/423?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-bHRpX2NvbnN1bWVyL2FwaS5weQ==) | `97.91% <75.00%> (-1.01%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mphilbrick211 commented 10 months ago

Hi @kuipumu! Would you mind rebasing this pull request? Doing so might help resolve the codecov errors. If that doesn't work, I'll look into it for you. Thanks!

mphilbrick211 commented 9 months ago

Hi @kuipumu! Would you mind rebasing this pull request? Doing so might help resolve the codecov errors. If that doesn't work, I'll look into it for you. Thanks!

Hi @kiram15! Friendly follow-up on this!

mphilbrick211 commented 6 months ago

Hi @kuipumu! Just checking in to see if you plan to pursue this pull request?

mphilbrick211 commented 5 months ago

Hi @kuipumu! I'm going to close this pull request for now, but we can reopen in the future if you'd like to pursue. Thanks!

openedx-webhooks commented 5 months ago

@kuipumu Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.