Open shadinaif opened 8 months ago
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
For your review @OmarIthawi, please
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.85%. Comparing base (
83fa9e0
) to head (c5851e6
).:exclamation: Current head c5851e6 differs from pull request most recent head f6fbae4. Consider uploading reports for the commit f6fbae4 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @shadinaif please update the following:
please check now @OmarIthawi
Hi @OmarIthawi and @shadinaif! Is this pull request still needed?
Yes @mphilbrick211, we needed it to get merged but it wasn't triaged since Jan 25th.
@shadinaif there's a new changelog update that conflicts with this pull request, kindly rebase and fix it.
Rebased. But codecov is failing for no reason ¯\(ツ)/¯
Hi @shadinaif and @OmarIthawi! Can this be closed?
Thanks @shadinaif. @mphilbrick211, this is now ready for merging. I don't have permissions though. Could you please help?
when the course id is a little bit long, the lti xblock id becomes too long for resource_id to handle
To reproduce:
course-v1:Public+TEST_IT_01+TEST_IT_01_Dec_2023
lti_consumer
in Advanced settings for the course1.3
we tried that on the latest https://sandbox.openedx.org