openedx / xblock-lti-consumer

GNU Affero General Public License v3.0
27 stars 80 forks source link

feat: use XBlockI18NService js translations | FC-0012 #441

Closed OmarIthawi closed 6 months ago

OmarIthawi commented 7 months ago

Implement OEP-58 JavaScript translations

Testing

Reference

This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.

openedx-webhooks commented 7 months ago

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

OmarIthawi commented 6 months ago

@shadinaif fyi.

e0d commented 6 months ago

@itsjeyd all the tests have passed, so removing the label.

itsjeyd commented 6 months ago

Thanks @e0d!

openedx-webhooks commented 6 months ago

@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

OmarIthawi commented 6 months ago

Thanks @shadinaif. I've closed it. You're right about the minor notes, Ahmed was being onboarded and I just opened the PR for him.

Please re-create the PR with your notes resolved.

shadinaif commented 6 months ago

thank you @OmarIthawi , replaced by this PR https://github.com/openedx/xblock-lti-consumer/pull/452