openedx / xblock-lti-consumer

GNU Affero General Public License v3.0
27 stars 80 forks source link

feat!: remove Transifex calls for FC-0012 - OEP-58 #445

Closed shadinaif closed 5 months ago

shadinaif commented 7 months ago

Breaking change!

This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.


This PR depends on https://github.com/openedx/xblock-lti-consumer/pull/452 and contains a cherry-pick from it until that one is merged


Changes

Merge timeline

This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.

The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.

## Keep this pull request as a draft to prevent an accidental merge. ##

Pre-merge checklist

References

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.

Join the conversation on Open edX Slack #translations-project-fc-0012.

Check the links above for full information about the overall project.

openedx-webhooks commented 7 months ago

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.83%. Comparing base (516d289) to head (a9239d2).

Files Patch % Lines
lti_consumer/lti_xblock.py 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #445 +/- ## ========================================== - Coverage 97.85% 97.83% -0.02% ========================================== Files 77 77 Lines 6705 6710 +5 ========================================== + Hits 6561 6565 +4 - Misses 144 145 +1 ``` | [Flag](https://app.codecov.io/gh/openedx/xblock-lti-consumer/pull/445/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openedx/xblock-lti-consumer/pull/445/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | `97.83% <91.66%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

OmarIthawi commented 5 months ago

done @brian-smith-tcril

openedx-webhooks commented 5 months ago

@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.