Closed shadinaif closed 5 months ago
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Attention: Patch coverage is 91.66667%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 97.83%. Comparing base (
516d289
) to head (a9239d2
).
Files | Patch % | Lines |
---|---|---|
lti_consumer/lti_xblock.py | 90.90% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
done @brian-smith-tcril
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Breaking change!
This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.
This PR depends on https://github.com/openedx/xblock-lti-consumer/pull/452 and contains a cherry-pick from it until that one is merged
Changes
tx pull
andtx push
commands from the XBlock to let Open edX manage it..po
or.mo
files will be committed into the repos.Makefile
targets and configuration files.Merge timeline
This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.
The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.
## Keep this pull request as a draft to prevent an accidental merge. ##
Pre-merge checklist
References
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.