openedx / xblock-lti-consumer

GNU Affero General Public License v3.0
27 stars 80 forks source link

feat: add i18n_js_namespace to support atlas - FC-0012 #452

Closed shadinaif closed 5 months ago

shadinaif commented 6 months ago

Implement OEP-58 JavaScript translations

Details:

Testing

Local tutor 17.0.2

References

This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.

openedx-webhooks commented 6 months ago

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

shadinaif commented 6 months ago

please review @OmarIthawi

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 97.77%. Comparing base (516d289) to head (a6180f8).

Files Patch % Lines
lti_consumer/utils.py 57.14% 3 Missing :warning:
lti_consumer/lti_xblock.py 93.75% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #452 +/- ## ========================================== - Coverage 97.85% 97.77% -0.08% ========================================== Files 77 77 Lines 6705 6736 +31 ========================================== + Hits 6561 6586 +25 - Misses 144 150 +6 ``` | [Flag](https://app.codecov.io/gh/openedx/xblock-lti-consumer/pull/452/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openedx/xblock-lti-consumer/pull/452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | `97.77% <83.33%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

OmarIthawi commented 5 months ago

@shadinaif please mark this one as draft!

OmarIthawi commented 5 months ago

being merged in https://github.com/openedx/xblock-lti-consumer/pull/445

openedx-webhooks commented 5 months ago

@shadinaif Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.