Closed shadinaif closed 5 months ago
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
please review @OmarIthawi
Attention: Patch coverage is 83.33333%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 97.77%. Comparing base (
516d289
) to head (a6180f8
).
Files | Patch % | Lines |
---|---|---|
lti_consumer/utils.py | 57.14% | 3 Missing :warning: |
lti_consumer/lti_xblock.py | 93.75% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@shadinaif please mark this one as draft!
being merged in https://github.com/openedx/xblock-lti-consumer/pull/445
@shadinaif Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.
Implement OEP-58 JavaScript translations
Details:
Testing
Local tutor 17.0.2
console.log(gettext('LTI Consumer'))
References
This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.