codecov[bot]
commented
5 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.83%. Comparing base (
1de6fa7) to head (e9bb1b2).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #460 +/- ## ======================================= Coverage 97.83% 97.83% ======================================= Files 77 77 Lines 6710 6710 ======================================= Hits 6565 6565 Misses 145 145 ``` | [Flag](https://app.codecov.io/gh/openedx/xblock-lti-consumer/pull/460/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openedx/xblock-lti-consumer/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | `97.83% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
TICKET: https://2u-internal.atlassian.net/browse/COSMO-227
It seems the css for the height of an LTI modal's iframe was set to "auto" (which seemed to be defaulting to 100vh), not 100%, which seems to have caused issues for some learners on iPads.
NOTE: I have yet to test this locally and I'm not sure I can, especially given that we can't use the IMS global to anymore.