search

openedx / xqueue-watcher

GNU Affero General Public License v3.0
17 stars 39 forks source link

update xqueue_watcher.jailedgrader to comply with Python 3.12's removal of `imp` module #109

Closed TheVinhLuong102 closed 10 months ago

TheVinhLuong102 commented 1 year ago

Python 3.12 has removed the imp standard library module.

This PR updates certain code modules from using the deprecated imp to using importlib functionalities instead.

openedx-webhooks commented 1 year ago

Thanks for the pull request, @TheVinhLuong102! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1aa0e58) 88.42% compared to head (ffcd93d) 88.56%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #109 +/- ## ========================================== + Coverage 88.42% 88.56% +0.14% ========================================== Files 6 6 Lines 475 481 +6 ========================================== + Hits 420 426 +6 Misses 55 55 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

itsjeyd commented 12 months ago

Hi @TheVinhLuong102, thank you for this contribution!

I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

itsjeyd commented 11 months ago

Hey @TheVinhLuong102, just checking in to see if you're still planning to continue working on this PR?

itsjeyd commented 10 months ago

Hi @TheVinhLuong102! Just a quick update that we're closing this PR now because it is stale. You may reopen this pull request, or open a new one, when you have time to come back to this work.

openedx-webhooks commented 10 months ago

@TheVinhLuong102 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.