search

openeemeter / eeweather

Fetch NCDC ISD, TMY3, or CZ2010 weather data that corresponds to ZIP Code Tabulation Areas or Latitude/Longitude.
http://eeweather.openee.io/
Apache License 2.0
50 stars 19 forks source link

created EEWeatherWarning #26

Closed ssuffian closed 6 years ago

codecov[bot] commented 6 years ago

Codecov Report

Merging #26 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          25     27    +2     
  Lines        2420   2453   +33     
=====================================
+ Hits         2420   2453   +33
Impacted Files Coverage Δ
eeweather/ranking.py 100% <100%> (ø) :arrow_up:
tests/test_warnings.py 100% <100%> (ø)
eeweather/__version__.py 100% <100%> (ø) :arrow_up:
tests/test_ranking.py 100% <100%> (ø) :arrow_up:
eeweather/warnings.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47be312...b0005b3. Read the comment docs.

philngo commented 6 years ago

Looks good to me. Maybe put the warnings into a new warnings.py file instead of utils.py? I think of utils.py as a miscellaneous module, so the less we can put in there the better in terms of clarity for newcomers.