search

openeew / openeew-dashboard

Dashboards for monitoring devices, events, users, data and more. Built on Carbon and React.
http://dashboard.openeew.com
Apache License 2.0
25 stars 32 forks source link

Updating prettier from 2.2.1 -> 2.3.0 #125

Closed EdrianI closed 3 years ago

EdrianI commented 3 years ago

Setting Prettier's version number on our GitHub Action and package.json. This will allow us to keep the checks synced. If we use a mismatched version, there is potential for formatting errors that are also mismatched. For example, 2.3.0 has more checks than 2.2.1, so the 2.3.0 prettier --check command can fail while 2.2.1 may pass.

The index.js file in this Pull Request was caught in the example situation.

EdrianI commented 3 years ago

Note the failing linter (pull_request_target) Action - this is failing because the master branch has the violation. This should go away when this PR is merged.