search

openeew / openeew-dashboard

Dashboards for monitoring devices, events, users, data and more. Built on Carbon and React.
http://dashboard.openeew.com
Apache License 2.0
25 stars 32 forks source link

'Cannot read property push of undefined' after finalizing onboarding #126

Open rdkelley opened 3 years ago

rdkelley commented 3 years ago

screen_after_add_to_device

krook commented 3 years ago

I've seen this in the context of the history object. Is that where you've already explored?

rdkelley commented 3 years ago

Yeah, I imagine it has something to do with history but haven't had the chance to troubleshoot it yet. I did refactor some of how history is used in the latest PR, so if we're lucky it might already be fixed in the staging deployment. I'm going to investigate more tomorrow.

rdkelley commented 3 years ago

Just tested -- this does not seem to be an issue in the current staging version, so I'm guessing the refactor of the history object in the latest PR fixed it. After we release v.0.8.0, we'll make sure that's accurate and close this issue.

krook commented 3 years ago

Sounds good. Even if it's not fixed, I think it's less a functional problem than a simple UI/navigation inconvenience. And if we can't get to the root cause later, maybe we just update error handling to look for it and ignore.

krook commented 2 years ago

Have we confirmed whether this has indeed been fixed @rdkelley?