search

openeew / openeew-provisioner

Provisioning app for OpenEEW sensor
Apache License 2.0
7 stars 6 forks source link

Add loading indicator / rudimentary error messages on failure #10

Closed gdpelican closed 3 years ago

johnwalicki commented 3 years ago

Hi James - I looked through the new code. I like the new loading spinner. I also saw your refactoring of the SmartConfig code into perform_smartconfig_request.dart When I provision my OpenEEW ESP32 it fails in line 21. Then it crashes out with lots of error details. My version had the return type as 'Map<String, dynamic>' I changed the code back to dynamic. I also had to parse the list differently to get the Mac Address. I brought back my chunk of code (with comments)

E/flutter (14866): [ERROR:flutter/lib/ui/ui_dart_state.cc(177)] Unhandled Exception: type '_InternalLinkedHashMap<String, dynamic>' is not a subtype of type 'Map<String, List<String>>'

johnwalicki commented 3 years ago

I created a new PR to parse the MAC address. https://github.com/openeew/openeew-provisioner/pull/11

gdpelican commented 3 years ago

Sweeet thanks for that! I'll have a quick peek and merge :)