search

openeew / openeew-provisioner

Provisioning app for OpenEEW sensor
Apache License 2.0
7 stars 6 forks source link

Warning when not using 2.4GHz network #33

Closed NavarroFer closed 3 years ago

NavarroFer commented 3 years ago

I found this package wifi_info_plugin that allows to get the frequency of the connected network. Closes #19

Changes where made in the page complete.dart Closes #27

NavarroFer commented 3 years ago

Hello! I'm a student from Universidad Nacional de Mar del Plata, My friend and I have been working on a college project and we've found your project on linuxfoundation.org and would like to make a collaboration to fix the issues #19 and #27. Please let us know what you think. Thank you!

By the way, the contributing page link you provided is not working! :)

NavarroFer commented 3 years ago

Hello! I'm a student from Universidad Nacional de Mar del Plata, My friend and I have been working on a college project and we've found your project on linuxfoundation.org and would like to make a collaboration to fix the issues #19 and #27. Please let us know what you think. Thank you!

By the way, the contributing page link you provided is not working! :)

johnwalicki commented 3 years ago

This is great! I looked over the patch. I want to compile and test it on 2.4Ghz and 5Ghz and mixed networks

NavarroFer commented 3 years ago

I'll do this changes!

johnwalicki commented 3 years ago

Thanks - I compiled and tested on various 2.4GHz / 5GHz / mixed networks. Took some screenshots.

You might want to join the OpenEEW Slack workspace. I posted the screenshots of the new changes in the #apps channel. See link on the upper right corner of https://openeew.com/

NahuelM97 commented 3 years ago

Hi! Nahuel here, Fer's project workmate. First of all, thank you for your review! We've made the change you suggested.

A small thing we thought we should mention: the values used in MIN_WIFI_FREQUENCY and MAX_WIFI_FREQUENCY are the standarized values specified in IEEE 802.11b. If you think the range should be a little bit more flexible, let us know and we'll change it! :)

johnwalicki commented 3 years ago

Fantastic - merging the PR.

andygrillo commented 3 years ago

Hola @NavarroFer y @NahuelM97 !

Mil gracias por tu trabajo. Ya tenemos la nueva version del app en el play store gracias a ustedes!

johnwalicki commented 3 years ago

@NavarroFer y @NahuelM97 - This improvement is now available in the Google Playstore. Thanks! We would welcome you in the OpenEEW Slack workspace. We have some more Flutter features we want to implement.