search

openego / data_processing

(geo)data processing, database setup, data validation
GNU Affero General Public License v3.0
7 stars 5 forks source link

Draft BPMN #337

Closed gplssm closed 3 years ago

gplssm commented 4 years ago

fix #335

IlkaCu commented 3 years ago

@gplssm: Could you have a look on the changes I added? As you intialized this PR I can't set you as a reviewer.

gplssm commented 3 years ago

Sure!

I cannot comment on the details of this, as I don't know more than you here. For me, in general, it looks meaningfull: relevant tables and scripts are connected. Missing datasets and script are highlighted in red. It's quite intuitive!

I was just wondering why there are some missing arrows?

ego_pp_bpmn_section_supply

IlkaCu commented 3 years ago

Obviously something went wrong here. This is not the final version I intended to merge. I will check that out.

IlkaCu commented 3 years ago

The image you posted shows the simple_feedin BPMN, but the PR aims to update ego_dp-pre_bpmn_section_supply.graphml for the supply section.

IlkaCu commented 3 years ago

I removed the redundant and incorrect file ego_pp_bpmn_section_supply.graphml which caused the confusion above.