search

openego / eGon-data

GNU Affero General Public License v3.0
10 stars 4 forks source link

PV rooftop fails in SH mode #1055

Closed nesnoj closed 1 year ago

nesnoj commented 1 year ago

In dev here you try to obtain the weather cells: https://github.com/openego/eGon-data/blob/4a2d0168ccd3deca5d8333ba1442b5b47ada90ab/src/egon/data/datasets/power_plants/pv_rooftop.py#L247-L255

This apparently works for DE but in SH mode the cfg is overwritten: https://github.com/openego/eGon-data/blob/4a2d0168ccd3deca5d8333ba1442b5b47ada90ab/src/egon/data/datasets/power_plants/pv_rooftop.py#L163-L164 which results in a key error later. This second assignment does not exist in the CI, why?

nesnoj commented 1 year ago

Seems that it has been added in 4a2d0168ccd3deca5d8333ba1442b5b47ada90ab

khelfen commented 1 year ago

Seems that it has been added in 4a2d016

Ah yes, you are right! Thank you for the fast fix! :D