search

openego / eGon-data

GNU Affero General Public License v3.0
10 stars 4 forks source link

Bug after merge in PV_ground_mounted #1078

Closed KathiEsterl closed 1 year ago

KathiEsterl commented 1 year ago

I adapted the scripts for PV ground mounted power plants to the new mastr-data. It looks like here @nesnoj overwrote my changes during a merge, so right now the script is not working.

It needs to be:

df = df[df["Lage"] == "Freifläche"] in src/egon/data/datasets/power_plants/pv_ground_mounted.py

nesnoj commented 1 year ago

Uh, I'm sorry for overlooking this! While the changes in 8e4079b29a9a2d752d73f77966d0036017ee1252 were intentional, this should have been changed again in d2fc0abd2f1f28e6f68cd09535ee706f8c746e57 (same thing for wind "Kuestenentfernung" -> "Windkraft an Land" which had been changed).

I'm wondering why the sanity checks did not reveal deviations (I guess 0 is considered to be be ok)? Thanks for fixing!

KathiEsterl commented 1 year ago

No worries!

I don't know how, but the "Kuestenentfernung" -> "Windkraft an Land"-thing somehow made it to the dev in the correct way, I think.

@CarlosEpia is checking the results of the new run in the next days, I think.

CarlosEpia commented 1 year ago

Hi! I took a look at the results and the onshore script is working as expected based on the results in sftp://egon@142.132.250.219/home/egon/ci/run-everything/working-directory

The total installed capacity is the required in supply.egon_scenario_capacities and the distribution of the generators across the country makes sense.