search

openego / eGon-data

GNU Affero General Public License v3.0
10 stars 4 forks source link

Carrier naming land transport EV within grid.egon_etrago_load #1105

Closed khelfen closed 1 year ago

khelfen commented 1 year ago

@nesnoj within the table grid.egon_etrago_load there are two carriers for EV at the moment. land transport EV and land_transport_EV. Is there any reasoning for that? Should we change land transport EV to land_transport_EV as at the moment it is the only carrier with whitespaces instead of underscores?

nesnoj commented 1 year ago

Hey @khelfen, I used land transport EV as it is used in p-e-s as well and I wanted to be in line with its carrier naming (which was also requested by @ClaraBuettner earlier). But I can alter this if needed. Moreover, I used further carriers with spaces such as BEV charger. Am I to adjust all of them?

@IlkaCu This was discussed yesterday but unfortunately I wasn't able to take part. Shall I change it?

khelfen commented 1 year ago

Hey @khelfen, I used land transport EV as it is used in p-e-s as well and I wanted to be in line with its carrier naming (which was also requested by @ClaraBuettner earlier). But I can alter this if needed. Moreover, I used further carriers with spaces such as BEV charger. Am I to adjust all of them?

@IlkaCu This was discussed yesterday but unfortunately I wasn't able to take part. Shall I change it?

In that case I'm just wondering where does land_transport_EV come from? I couldn't find it mentioned in the code base anywhere. TBH land transport EV is fine with me (having your reasoning in mind) but the double naming is confusing :thinking:

nesnoj commented 1 year ago

In that case I'm just wondering where does land_transport_EV come from? I couldn't find it mentioned in the code base anywhere. TBH land transport EV is fine with me (having your reasoning in mind) but the double naming is confusing thinking

I found some replacements for the p-e-s components here (search for carrier.str.replace(" ", "_")) but this only covers neighboring countries, doesn't it? @IlkaCu @ClaraBuettner Please drop us a note if you have more information or a clear opinion how to proceed.

nesnoj commented 1 year ago

From today's webco: I will rename the carriers

khelfen commented 1 year ago

From today's webco: I will rename the carriers

@mltja FYI

nesnoj commented 1 year ago

I checked the DB tables and it depends on the scnenario: