Change eMob MIT carrier names in eMob model timeseries generation

nesnoj commented 1 year ago

Fixes #1105

Hey @ClaraBuettner and @IlkaCu, here comes the carrier renaming.

One question: I did not alter the parameters.py file as they seem to apply only to the stationary batteries - I was quickly wondering that here you use battery storage as well but this is only to parametrize your storages which have other carrier names, right?

One reviewer is enough. Thanks! :)

Before merging into `dev`-branch, please make sure that

[x] the CHANGELOG.rst was updated.
[x] new and adjusted code is formated using black and isort.
[x] the Dataset-version is updated when existing datasets are adjusted.
[x] the branch was merged into the continuous-integration/run-everything-over-the-weekend-branch.
[ ] the workflow is running successful in test mode.
[x] the workflow is running successful in Everything mode.

ClaraBuettner commented 1 year ago

Looking at the code, the changes are fine. I did not tested it, maybe it is enough to test it on CI?

And yes, in parameters.py the "battery storage" parameters are used for larger batteries in the system. The name is only used internally in egon-data, so we can probably accept the inconsistency.

nesnoj commented 1 year ago

Looking at the code, the changes are fine. I did not tested it, maybe it is enough to test it on CI?

And yes, in parameters.py the "battery storage" parameters are used for larger batteries in the system. The name is only used internally in egon-data, so we can probably accept the inconsistency.

Thank you, merged into CI! :)

openego / eGon-data