search

openego / eTraGo

Optimization of flexibility options for transmission grids based on PyPSA
GNU Affero General Public License v3.0
32 stars 13 forks source link

Reformat code and squelch a few `flake8` complaints #558

Closed gnn closed 1 year ago

gnn commented 1 year ago

Finally got around to creating a pull request with the cleanup I made while working on disaggregating the new sectors. Please have a look and make sure that I didn't make any breaking changes. One note: the == False and similar patterns is something that also cropped up in egon-data so I'm pointing it out here because it can easily be avoided. It's not really wrong. Just weird. :)

gnn commented 1 year ago

Sorry, that was to early. I still have to squash some commits and do a force push.

gnn commented 1 year ago

Squashed all temporary commits and fixed the conflicts by "rebasing" onto an updated "dev". The new code also uncovered that sometimes, using == False really is the wrong thing to do. ;) Have fun reviewing.

ClaraBuettner commented 1 year ago

I had a brief look at the code changes which look fine for me. I tried to run this branch, but run into problems which are already fixed on dev but not part of this branch yet. When dev is merged into this branch, I will give it another try.