openego / eTraGo

Optimization of flexibility options for transmission grids based on PyPSA
GNU Affero General Public License v3.0
30 stars 13 forks source link

Documentation release0.9.0 #634

Closed KathiEsterl closed 1 year ago

KathiEsterl commented 1 year ago

I requested all of you as reviewers who have been working with this branch. When approving, you confirm that you have finished everything you wanted to do here.

Please also have another look into the read-the-docs before approving. I noticed the following:

ClaraBuettner commented 1 year ago

I'm done with my part of the documentation update (at least for all the changes on the current dev). But I had some questions regarding the changes in the other sections and files. I was not sure who of you did which changes, but could you maybe have a look at the comments and answer in case you were the one doing the change?

I also noticed that we switch quite often from British English to American English (especially optimization is written in both options). It is not very urgent to change this, but in case you do some changes anyways, it would be good to align the language. Since the old parts are written in American English, I would prefer to stick to this option.

KathiEsterl commented 1 year ago

I'm done with my part of the documentation update (at least for all the changes on the current dev). But I had some questions regarding the changes in the other sections and files. I was not sure who of you did which changes, but could you maybe have a look at the comments and answer in case you were the one doing the change?

I also noticed that we switch quite often from British English to American English (especially optimization is written in both options). It is not very urgent to change this, but in case you do some changes anyways, it would be good to align the language. Since the old parts are written in American English, I would prefer to stick to this option.

I resolved the issues within my responsibilites and also checked my text to stick to American English. Thanks for your remarks!

ClaraBuettner commented 1 year ago

I guess the 4th point is already fixed, right @CarlosEpia? Besides, I updated the list of new features from the ticket and copied it into the rtd in this branch. We can definitely still changes this there, but I thought it would be easier to have everything in one branch.

CarlosEpia commented 1 year ago

I guess the 4th point is already fixed, right @CarlosEpia? Besides, I updated the list of new features from the ticket and copied it into the rtd in this branch. We can definitely still changes this there, but I thought it would be easier to have everything in one branch.

Yes. It is already solved. I just ticked the box. About the list of new features, I think it is better to have them in the same branch with all the other changes as you proposed.

KathiEsterl commented 1 year ago

I updated the explanation on the temporal disaggregation and merged dev.

I think at least @ClaraBuettner , @pieterhexen and me are done with changing our parts and checking the whole thing (briefly), right? What about you, @CarlosEpia ? There is this one comment by Clara left, could you have a look?

@ClaraBuettner you said, the spatial disaggregation has to be added to the Whats New-Section. Are you gonna do that witin the features-Branch, do we just already want to add it here or do we wait for this branch to merge until it is working and we can add it here?

Afterwards, could everybody please approve if you are confident with the things done here? Maybe I could merge then?

ClaraBuettner commented 1 year ago

I updated the explanation on the temporal disaggregation and merged dev.

I think at least @ClaraBuettner , @pieterhexen and me are done with changing our parts and checking the whole thing (briefly), right?

Yes, I'm done with my changes.

@ClaraBuettner you said, the spatial disaggregation has to be added to the Whats New-Section. Are you gonna do that witin the features-Branch, do we just already want to add it here or do we wait for this branch to merge until it is working and we can add it here?

I will add it on the other branch. And we also have to insert the release day, but I will do that directly on the release branch.

Afterwards, could everybody please approve if you are confident with the things done here? Maybe I could merge then?

Yes, I will approve it now.

pieterhexen commented 1 year ago

I think at least @ClaraBuettner , @pieterhexen and me are done with changing our parts and checking the whole thing (briefly), right? What about you, @CarlosEpia ? There is this one comment by Clara left, could you have a look?

Yes, I am done