openego / ego.powerflow

A power flow app to solve AC and DC powerflow problems using PyPSA
GNU Affero General Public License v3.0
5 stars 3 forks source link

Merge 'refactor/upgrade-to-pypsa-0.8' into dev #30

Closed gplssm closed 7 years ago

gplssm commented 7 years ago

Understand why Dingo produces different results with PyPSA 0.6.2 and 0.8.0

First you should make sure Dingo produces reproducible results: run multiple times with same setting and compare results.

Possible reasons

  1. API changes, i.e. p_min_pu/p_max_pu changed as @ulfmueller explained. See in what's new of 0.7.0, what's new of 0.7.1 and what's new of 0.8.0
  2. Algorithms for PF in PyPSA changed

A basic analysis script to compare to Dingo results is available here

Note, there exists a new branch branched from 'refactor/upgrade-to-pypsa-0.8' which contains latest development of ZNES/NExt Energy.

gplssm commented 7 years ago

The analysis of Dingo shows multiple runs return a different grid topology. On the example of MV grid 3545 it shows that the grid has sometime 280 nodes and on other runs 281 nodes. But, this is independent from PyPSA and different versions of PyPSA (see point 5 of the dingo issue).

Nevertheless, comparing nodes attributes (in particular results obtained from the power flow analysis) of runs with PyPSA 0.6.2 and PyPSA 0.8.0 shows good conformity. The voltage level resulting from the power flow analysis only deviates in the 10th decimal place. Comparing edges data from both runs are perfect match of data is observed.

To conclude, switching from PyPSA 0.6.2 to 0.8.0 does not affect Dingo results. :tada: :postal_horn:

gplssm commented 7 years ago

Merge is done!

ulfmueller commented 7 years ago

Would be nice to see if also 'our state of the art' branch network-from-grid can be merged into dev too... maybe we can talk about that soon. In eTraGo we have been working with that branch in order to also access the grid schema and have some structural improvements. I can create an issue for that eventually...