openego / powerd-data

GNU Affero General Public License v3.0
1 stars 0 forks source link

Fixes/#221 include decommission date for generators #223

Closed CarlosEpia closed 3 months ago

CarlosEpia commented 3 months ago

Fixes #221.

CarlosEpia commented 3 months ago

I just made two small suggestions and the part for pv rooftop is missing. I did not test the code, but it looks like it should work :)

@khelfen What do you think if we create a new issue to deal with the new filters for generators in future scenarios? I would like to close this issue related to the "status" scenarios soon and changing all the scrips for eGon2035 and eGon100RE looks like a task that could take some time

khelfen commented 3 months ago

I just made two small suggestions and the part for pv rooftop is missing. I did not test the code, but it looks like it should work :)

@khelfen What do you think if we create a new issue to deal with the new filters for generators in future scenarios? I would like to close this issue related to the "status" scenarios soon and changing all the scrips for eGon2035 and eGon100RE looks like a task that could take some time

That's fine with me :)

CarlosEpia commented 3 months ago

Since the comments were already addressed, I proceed to merge this branch.