CI does not cover pull requests?

openela / openela.org

https://openela.org

BSD 3-Clause "New" or "Revised" License

26 stars 16 forks source link

CI does not cover pull requests? #18

Open hartwork opened 8 months ago

hartwork commented 8 months ago

Hi!

The CI at https://github.com/openela/openela.org/blob/main/.github/workflows/hugo.yaml seems to only run when (a) pushed to master or (b) when manually triggered but not for pull requests. In that current setup, it will be possible for pull requests to break master and only notice that after merge. Is that beneficial and intended?

Best, Sebastian

NeilHanlon commented 7 months ago

Definitely. We are going to be using prow as part of our CI for the entire organization, and this will be managed in a similar way.

Thank you for noticing and reporting this!

hartwork commented 7 months ago

@NeilHanlon use of prow sounds a like a bigger migration? I think before a migrating to prow all it would take if wanted would be to:

Add pull_request to https://github.com/openela/openela.org/blob/92fe9fde5bba04e654ac2dd269a05e05be6f558f/.github/workflows/hugo.yaml#L3
Exclude job deploy from pull requests (probably by adding a condition)

Just an idea.

NeilHanlon commented 7 months ago

You're right. I'll get to this today :)