openembedded / meta-openembedded

MIT License
415 stars 712 forks source link

nodejs: Add PACKAGECONFIG share to allow other projects to use node as library #656

Closed ArchanaWind closed 1 year ago

ArchanaWind commented 1 year ago

Hi ,

The mentioned commit is adding the below snippet to to the Nodejs recipe

@@ -99,6 +101,7 @@ do_configure () { ./configure --prefix=${prefix} --without-snapshot --shared-openssl \ --dest-cpu="${@map_nodejs_arch(d.getVar('TARGET_ARCH'), d)}" \ --dest-os=linux \

In the above code snipped can we use --libdir=${libdir} instead of --libdir=${D}${libdir}. because due to ${D}${libdir} getting below do_package_QA warnings

WARNING: nodejs-16.18.1-r0 do_package_qa: QA Issue: File /usr/bin/.debug/node in package nodejs-dbg contains reference to TMPDIR [buildpaths] WARNING: nodejs-16.18.1-r0 do_package_qa: QA Issue: File /usr/include/node/config.gypi in package nodejs-dev contains reference to TMPDIR [buildpaths] WARNING: nodejs-16.18.1-r0 do_package_qa: QA Issue: File /usr/bin/node in package nodejs contains reference to TMPDIR [buildpaths] NOTE: Tasks Summary: Attempted 1028 tasks of which 0 didn't need to be rerun and all succeeded.

Could you please suggest can we use --libdir=${libdir} instead of --libdir=${D}${libdir}

Thanks in advance.

kraj commented 1 year ago

seems fine, please testout the fix

ArchanaWind commented 1 year ago

Thank you for quick response

shr-project commented 1 year ago

@ArchanaWind

This broke do_install with "shared" PACKAGECONFIG enabled as reported on ML: https://lists.openembedded.org/g/openembedded-devel/message/101084 https://lists.openembedded.org/g/openembedded-devel/message/101085

see the fix in https://lists.openembedded.org/g/openembedded-devel/message/101088