openembedded / meta-openembedded

MIT License
398 stars 690 forks source link

xscreensaver: why are glx hacks disabled? #734

Open argosphil opened 11 months ago

argosphil commented 11 months ago

I stumbled across this while playing with OpenGL on an embedded device:

https://github.com/openembedded/meta-openembedded/blob/c1dd0ff02dc804002cdf0a05b1742623612e524e/meta-oe/recipes-graphics/xscreensaver/files/0002-build-Do-not-build-po-files.patch#L26-L29

The commit removes the hacks/glx directory without explanation. Was that by mistake? I've tried and while the recipe needed some adjustment in my case, the GLX hacks work fine once reenabled by undoing part of that patch.

[edited to expand the included snippet)

kraj commented 11 months ago

@argosphil its an oversight, only po generation is supposed to be removed by this patch. Can you submit your changes to this patch to re-enable glx hacks a PR