search

openembedded / meta-openembedded

MIT License
402 stars 700 forks source link

avro: extend avro-c++ to native and nativesdk #812

Closed RuiMarioCosta closed 5 months ago

RuiMarioCosta commented 5 months ago
shr-project commented 5 months ago

Please fix the issues reported in https://github.com/openembedded/meta-openembedded/pull/807 first.

RuiMarioCosta commented 5 months ago

@shr-project I fixed the multilib build but I still get a warning saying 

WARNING: avro-c++-1.11.3-r0 do_package_qa: QA Issue: avro-c++-dbg: found library in wrong location: /usr/lib/.debug/libavrocpp.so.1.11.3-lib64
avro-c++-dev: found library in wrong location: /usr/lib/libavrocpp.so.1.11.3-lib64 [libdir]

I get what the issue is but by looking at some of the other recipes I don't understand what could I do different in the recipe. Do you know what could solve this?

shr-project commented 5 months ago

@shr-project I fixed the multilib build but I still get a warning saying

WARNING: avro-c++-1.11.3-r0 do_package_qa: QA Issue: avro-c++-dbg: found library in wrong location: /usr/lib/.debug/libavrocpp.so.1.11.3-lib64
avro-c++-dev: found library in wrong location: /usr/lib/libavrocpp.so.1.11.3-lib64 [libdir]

I get what the issue is but by looking at some of the other recipes I don't understand what could I do different in the recipe. Do you know what could solve this?

"-lib64" suffix at the end doesn't look like correct fix, did you use CMAKE_INSTALL_LIBDIR as DESTINATION?

There are many examples how to fix it in https://git.openembedded.org/meta-openembedded/log/?h=scarthgap&qt=grep&q=libdir

RuiMarioCosta commented 5 months ago

@shr-project I fixed the multilib build but I still get a warning saying

WARNING: avro-c++-1.11.3-r0 do_package_qa: QA Issue: avro-c++-dbg: found library in wrong location: /usr/lib/.debug/libavrocpp.so.1.11.3-lib64
avro-c++-dev: found library in wrong location: /usr/lib/libavrocpp.so.1.11.3-lib64 [libdir]

I get what the issue is but by looking at some of the other recipes I don't understand what could I do different in the recipe. Do you know what could solve this?

"-lib64" suffix at the end doesn't look like correct fix, did you use CMAKE_INSTALL_LIBDIR as DESTINATION?

There are many examples how to fix it in https://git.openembedded.org/meta-openembedded/log/?h=scarthgap&qt=grep&q=libdir

@shr-project you were right, I had the cmake install paths hardcoded in the patch file. It should be fixed now. Thanks

RuiMarioCosta commented 5 months ago

Hello @shr-project can you give me an estimate of when this will be merged?

RuiMarioCosta commented 5 months ago

Hello @shr-project can you give me an estimate of when this will be merged?

Nevermind, just checked in master and the commit is there. I was waiting for this PR to be closed like in the other case. In that case can this PR be closed?

kraj commented 5 months ago

Merged c4107ba77e70451c4033ccee658c19a1da44df4f