search

openembedded / meta-openembedded

MIT License
416 stars 716 forks source link

python3-twisted: Fix broken package split #823

Closed Hains closed 6 months ago

Hains commented 6 months ago

Without FILES:${PN} only main, dbg, dev, doc and test packages are being build. python3-twisted-core, python3-twisted-web, python3-twisted-conch, etc are missing.

Add python3-twisted-newsfragments to packages to fix.

WARNING: python3-twisted-24.3.0-r0 do_package: QA Issue: python3-twisted: Files/directories were installed but not shipped in any package: /usr/lib/python3.12/site-packages/twisted/newsfragments /usr/lib/python3.12/site-packages/twisted/newsfragments/.gitignore

gudnimg commented 6 months ago

Wouldnt it be simpler to remove the newsfragment directory in do_install:append? That way we can skip creating a new package python3-twisted-newsfragment. This directory is only used during development to compile the release notes. Once a release is finished the directory is emptied.

See for example the current development: https://github.com/twisted/twisted/tree/trunk/src/twisted/newsfragments

I don’t see why anyone would want to install that one .gitignore file :)

Hains commented 6 months ago

Yes indeed, it's just a .gitignore file.

New commit: https://github.com/Hains/meta-openembedded/commit/25cfb56eaaf82eabe8d050dcdf5daebf840c4fa4

Hains commented 6 months ago

PR V2 https://github.com/openembedded/meta-openembedded/pull/824

This patch can be removed from master-next branch. Thanks.

Hains commented 6 months ago

New PR.

gudnimg commented 6 months ago

@kraj FYI I sent two backport patches to sync the scarthgap branch with master since it will likely also have this problem.