openembedded / meta-openembedded

MIT License
402 stars 700 forks source link

libcamera: Use multiple of sizeof as malloc size #852

Closed hubertwisniewski0 closed 1 month ago

hubertwisniewski0 commented 2 months ago

Mallocs being the subject of this patch replace VLAs (patch 0001-rpi-Use-alloca-instead-of-variable-length-arrays.patch), so they should allocate memory in blocks whose sizes are multiples of the respective types' sizes.

hubertwisniewski0 commented 2 months ago

This patch fixes the problem introduced by patch 0001-rpi-Use-alloca-instead-of-variable-length-arrays.patch, which has been rejected by upstream [PATCH] rpi: Use alloca instead of variable length arrays but is still here anyway (with Upstream-Status: Submitted). So, either this patch should be added or the 0001 patch should be removed (or perhaps they should be merged and submitted to upstream?).

kraj commented 2 months ago

This patch fixes the problem introduced by patch 0001-rpi-Use-alloca-instead-of-variable-length-arrays.patch, which has been rejected by upstream [PATCH] rpi: Use alloca instead of variable length arrays but is still here anyway (with Upstream-Status: Submitted). So, either this patch should be added or the 0001 patch should be removed (or perhaps they should be merged and submitted to upstream?).

in that case just do this changes in original patch and mark the patch as "rejected" we need to restart submission with v2

kraj commented 1 month ago

applied with 4642c541c4f4f368941ce3956ad47c787bfb2a35