openembedded / meta-openembedded

MIT License
409 stars 709 forks source link

polkit: including system-auth in pam file instead of common-* #860

Closed FederAndInk closed 1 month ago

FederAndInk commented 2 months ago

Polkit pam file is trying to include non existant system-auth, if I understand correctly, OE is using common-* pam files instead.

This was working fine on kirkstone with a patch, but it was removed with the 0.119 recipe in https://git.openembedded.org/meta-openembedded/commit/meta-oe/recipes-extended/polkit?id=02e20ddb169fea0c387f70e1ba70ef676082edc0

The removed patch: https://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-extended/polkit/polkit/polkit-1_pam.patch?id=1f2c2ebcbcf5944225462f530e0d56b20f1b4630

Should it be re-included in the polkit recipe, or was it removed/not put on purpose?

kraj commented 2 months ago

hmm it might be a fallout from removal, we should forward port the said patch to current version of polkit

ycongal-smile commented 1 month ago

I'll look into this

ycongal-smile commented 1 month ago

Two alternative proposals (following Peter Kjellerstedt review):