android-tools: Fix inconsistency between selinux configurations - Githubissues

openembedded / meta-openembedded

MIT License

416 stars 719 forks source link

android-tools: Fix inconsistency between selinux configurations #866

Open quic-raghuvar opened 2 months ago

quic-raghuvar commented 2 months ago

ConditionPathExists is set to /etc/usb-debugging-enabled as part of meta-oe/ recipes-devtools/android-tools/android-tools/android-tools-adbd.service file. However, in meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/ android-tools/android-tools-adbd.service file ConditionPathExists is set to /var/usb-debugging-enabled

This causes an internal inconsistency between selinux-enabled and -disabled configurations.

Hence, change ConditionPathExists=/var/usb-debugging-enabled to ConditionPathExists=/etc/usb-debugging-enabled

Reported-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org

lumag commented 2 months ago

No DCO trailer
Author is incorrect

I hoped that mentioning it once should be enough.

lumag commented 2 months ago

Not to mention that there is no inconsistency before #862 gets merged. This commit should be a part of that pull request rather than a separate one.

quic-raghuvar commented 2 months ago

@lumag Do you want me to mention both Reported-by And Signed-off-by?

lumag commented 2 months ago

@quic-raghuvar huh? Reported-by is for me reporting the issue. Signed-off-by shows another fact about the patch author. Have you read what does it actually mean?

lumag commented 2 months ago

And the Author field is an internal git metadata. Due to .git misconfiguration on your side you have your account name written there. Please make sure to fix the configuration on your side then use a special argument of git commit to reset author's name.

If you are using the GitHub's web interface, please stop doing that. It might end up in different kinds of the issues, incuding, but not limited to metadata, whitespaces, etc. And by using web interface you are not testing your changes.

lumag commented 2 months ago

author is still incorrect
no empty lines between tags

You didn't answer. Have you read what does Signed-off-by signify?

quic-raghuvar commented 2 months ago

Some sources mentioned to add signed-off-by for DCO.

lumag commented 2 months ago

What is DCO? You didn't add it beforehand, that's why I'm trying to make sure that you understand it.

quic-raghuvar commented 2 months ago

Okay. I uploaded a new commit with no line space between tags. Also, I guess it got merged hence, turned out to be a new commit.

lumag commented 2 months ago

No, it wasn't merged. Please use git commit --amend and force-pushes.

lumag commented 2 months ago

@quic-raghuvar any updates for these patches? This can not be merged as it is now.