search

openemr / oe-schematron-service

0 stars 0 forks source link

Update Schematron to latest HL7 validation file #3

Closed adunsulag closed 2 years ago

adunsulag commented 2 years ago

HL7 has a new validation file available here: https://github.com/HL7/CDA-ccda-2.1/tree/master/schematron

Our CDA validations are not matching what is coming out of the Edge Testing Tool (ETT). Looking at HL7's schematrons it looks like it was updated 20 days ago. We need to use the latest version and hopefully that will catch the errors that were not being caught previously by our schematron validation.

sjpadgett commented 2 years ago

cool let me test as i'm looking over now

adunsulag commented 2 years ago

I'm just pushing out the PR now.

adunsulag commented 2 years ago

@sjpadgett Can you add me to the packagist for this package or create a new release 1.1.1 on packagist so we can get the update?

sjpadgett commented 2 years ago

yeah, let me catch up with you first. I pulled new rules and am testing now. Then i'll pull this, publish and add you to account.

sjpadgett commented 2 years ago

@adunsulag any reason you didn't include new voc.xml?

adunsulag commented 2 years ago

@sjpadgett I downloaded the file and it was the exact same as what was in the repository.

sjpadgett commented 2 years ago

okay however so far not making a difference in results. I'm not even getting warning so something is off. I'm going to go ahead and publish this and continue testing.

adunsulag commented 2 years ago

yea, I'm not seeing any changes as well. Trying to figure out if there is another validator as the ETT tools are failing the MDHT validation. I would have thought the schematron would be doing whatever the MDHT validation is doing:

image

This is with the NT_Bad_AllergyConcernElements_r11_v3.xml in the full ETT CCDA 2.1 test deck.

adunsulag commented 2 years ago

@sjpadgett Lovely... look at this thread. ETT does not use the schematron at all. It uses a completely different project called MDHT: https://groups.google.com/g/edge-test-tool/c/MsxjYmV5FJw/m/eERg2useBAAJ

adunsulag commented 2 years ago

https://github.com/onc-healthit/reference-ccda-validator/ is the validator rest API:

Here is how they call the API: https://github.com/onc-healthit/ett/blob/master/webapp/src/main/groovy/gov/nist/healthcare/ttt/webapp/direct/controller/CCDAValidatorController.groovy

Here is the library they are calling. https://github.com/mdht/mdht

sjpadgett commented 2 years ago

Tomcat or scaredy cat!

cat-gd7e5eeba3_640

stephenwaite commented 2 years ago

I'm scared of that claw!

sjpadgett commented 2 years ago

That claw is for scratching my head!