openenclave / oeedger8r-cpp

An implementation of oeedger8r in C++
MIT License
8 stars 13 forks source link

Fixed typo for "Ubuntu" #57

Closed Zildj1an closed 3 years ago

Zildj1an commented 4 years ago

Fixed typo. Signed-off-by: Carlos Bilbao bilbao@vt.edu

oe-ci-robot commented 4 years ago

Hi @Zildj1an. Thanks for your PR.

I'm waiting for a openenclave member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
oe-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Zildj1an To complete the pull request process, please assign anakrish You can assign the PR to them by writing /assign @anakrish in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openenclave/oeedger8r-cpp/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Zildj1an commented 4 years ago

/assign @anakrish

BRMcLaren commented 4 years ago

@Zildj1an I'm trying to understand why 1 DCO bot failed and one succeeded. We are moving away from the failed one regardless but it's interesting. When you signed off, did you do so with the -s flag, or manually?

Zildj1an commented 4 years ago

@BRMcLaren I signed it manually. I am sorry I cannot be of more help about that!

BRMcLaren commented 4 years ago

@BRMcLaren I signed it manually. I am sorry I cannot be of more help about that!

This is interesting, I think the DCO bot is specifically looking for angled brackets around the e-mail on the signoff. But it doesn't look for it with Prow's integrated bot. This was someone else's theory but it holds up: https://github.com/openenclave/oeedger8r-cpp/pull/53/commits

It mentions that the commit is not signed off, would you mind-altering your commit message and then signing with the remediation guidance? I personally like using the "-s" flag as it helps to avoid issues such as this.

BRMcLaren commented 4 years ago

/ok-to-test

oe-ci-robot commented 3 years ago

@Zildj1an: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pr-oeedger8r-cpp-Rhel8BuildClang-8 66864e9ab2fa90f45aaace926faad3d1d3c70e5f link /test pr-oeedger8r-cpp-Rhel8BuildClang-8
pr-oeedger8r-cpp-Rhel8BuildGCC 66864e9ab2fa90f45aaace926faad3d1d3c70e5f link /test pr-oeedger8r-cpp-Rhel8BuildGCC
pr-oeedger8r-cpp-Ubuntu1604BuildClang-7 66864e9ab2fa90f45aaace926faad3d1d3c70e5f link /test pr-oeedger8r-cpp-Ubuntu1604BuildClang-7
pr-oeedger8r-cpp-Ubuntu1604BuildGCC 66864e9ab2fa90f45aaace926faad3d1d3c70e5f link /test pr-oeedger8r-cpp-Ubuntu1604BuildGCC
pr-oeedger8r-cpp-Ubuntu1804BuildClang-7 66864e9ab2fa90f45aaace926faad3d1d3c70e5f link /test pr-oeedger8r-cpp-Ubuntu1804BuildClang-7
pr-oeedger8r-cpp-Ubuntu1804BuildGCC 66864e9ab2fa90f45aaace926faad3d1d3c70e5f link /test pr-oeedger8r-cpp-Ubuntu1804BuildGCC
pr-oeedger8r-cpp-Windows2016Build 66864e9ab2fa90f45aaace926faad3d1d3c70e5f link /test pr-oeedger8r-cpp-Windows2016Build
pr-oeedger8r-cpp-Windows2019Build 66864e9ab2fa90f45aaace926faad3d1d3c70e5f link /test pr-oeedger8r-cpp-Windows2019Build
pr-oeedger8r-cpp-ping 66864e9ab2fa90f45aaace926faad3d1d3c70e5f link /test pr-oeedger8r-cpp-ping
pr-oeedger8r-cpp-Ubuntu1804BuildClang-8 66864e9ab2fa90f45aaace926faad3d1d3c70e5f link /test pr-oeedger8r-cpp-Ubuntu1804BuildClang-8
pr-oeedger8r-cpp-Ubuntu1604BuildClang-8 66864e9ab2fa90f45aaace926faad3d1d3c70e5f link /test pr-oeedger8r-cpp-Ubuntu1604BuildClang-8

Full PR test history. Your PR dashboard. Please help us cut down on flakes by opening an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
CyanDevs commented 3 years ago

Closing as this was fixed in https://github.com/openenclave/oeedger8r-cpp/pull/83/