Closed Zildj1an closed 3 years ago
Hi @Zildj1an. Thanks for your PR.
I'm waiting for a openenclave member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Zildj1an
To complete the pull request process, please assign anakrish
You can assign the PR to them by writing /assign @anakrish
in a comment when ready.
The full list of commands accepted by this bot can be found here.
/assign @anakrish
@Zildj1an I'm trying to understand why 1 DCO bot failed and one succeeded. We are moving away from the failed one regardless but it's interesting. When you signed off, did you do so with the -s flag, or manually?
@BRMcLaren I signed it manually. I am sorry I cannot be of more help about that!
@BRMcLaren I signed it manually. I am sorry I cannot be of more help about that!
This is interesting, I think the DCO bot is specifically looking for angled brackets around the e-mail on the signoff. But it doesn't look for it with Prow's integrated bot. This was someone else's theory but it holds up: https://github.com/openenclave/oeedger8r-cpp/pull/53/commits
It mentions that the commit is not signed off, would you mind-altering your commit message and then signing with the remediation guidance? I personally like using the "-s" flag as it helps to avoid issues such as this.
/ok-to-test
@Zildj1an: The following tests failed, say /retest
to rerun all failed tests:
Test name | Commit | Details | Rerun command |
---|---|---|---|
pr-oeedger8r-cpp-Rhel8BuildClang-8 | 66864e9ab2fa90f45aaace926faad3d1d3c70e5f | link | /test pr-oeedger8r-cpp-Rhel8BuildClang-8 |
pr-oeedger8r-cpp-Rhel8BuildGCC | 66864e9ab2fa90f45aaace926faad3d1d3c70e5f | link | /test pr-oeedger8r-cpp-Rhel8BuildGCC |
pr-oeedger8r-cpp-Ubuntu1604BuildClang-7 | 66864e9ab2fa90f45aaace926faad3d1d3c70e5f | link | /test pr-oeedger8r-cpp-Ubuntu1604BuildClang-7 |
pr-oeedger8r-cpp-Ubuntu1604BuildGCC | 66864e9ab2fa90f45aaace926faad3d1d3c70e5f | link | /test pr-oeedger8r-cpp-Ubuntu1604BuildGCC |
pr-oeedger8r-cpp-Ubuntu1804BuildClang-7 | 66864e9ab2fa90f45aaace926faad3d1d3c70e5f | link | /test pr-oeedger8r-cpp-Ubuntu1804BuildClang-7 |
pr-oeedger8r-cpp-Ubuntu1804BuildGCC | 66864e9ab2fa90f45aaace926faad3d1d3c70e5f | link | /test pr-oeedger8r-cpp-Ubuntu1804BuildGCC |
pr-oeedger8r-cpp-Windows2016Build | 66864e9ab2fa90f45aaace926faad3d1d3c70e5f | link | /test pr-oeedger8r-cpp-Windows2016Build |
pr-oeedger8r-cpp-Windows2019Build | 66864e9ab2fa90f45aaace926faad3d1d3c70e5f | link | /test pr-oeedger8r-cpp-Windows2019Build |
pr-oeedger8r-cpp-ping | 66864e9ab2fa90f45aaace926faad3d1d3c70e5f | link | /test pr-oeedger8r-cpp-ping |
pr-oeedger8r-cpp-Ubuntu1804BuildClang-8 | 66864e9ab2fa90f45aaace926faad3d1d3c70e5f | link | /test pr-oeedger8r-cpp-Ubuntu1804BuildClang-8 |
pr-oeedger8r-cpp-Ubuntu1604BuildClang-8 | 66864e9ab2fa90f45aaace926faad3d1d3c70e5f | link | /test pr-oeedger8r-cpp-Ubuntu1604BuildClang-8 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by opening an issue when you hit one in your PR.
Closing as this was fixed in https://github.com/openenclave/oeedger8r-cpp/pull/83/
Fixed typo. Signed-off-by: Carlos Bilbao bilbao@vt.edu