Update the generated variable names to conform OE guidelines

openenclave / oeedger8r-cpp

An implementation of oeedger8r in C++

MIT License

8 stars 13 forks source link

Update the generated variable names to conform OE guidelines #66

Closed mingweishih closed 3 years ago

mingweishih commented 3 years ago

This PR updates generated variable names to conform the developer guidelines of OE. The detail includes

No longer use double underscores
- __oe_ecalls_table -> oe_ecalls_table (which will be referenced by the OE runtime)
- __foo_ocall_function_table -> _foo_ocall_function_table (only used in the local file)
Add underscore to the local variables
Remove underscore from the struct members

Refer to https://github.com/openenclave/openenclave/issues/3210 for more detail.

Signed-off-by: Ming-Wei Shih mishih@microsoft.com

mingweishih commented 3 years ago

Thanks for doing this. Are these the only non-conformant variables, or would there be more?

This should cover all the cases in the oeeger8r-generated code.

Would the user have to make any changes in their code due to the renamed variables?

User shouldn't be affected by these changes.

oe-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anakrish, mingweishih

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openenclave/oeedger8r-cpp/blob/master/OWNERS)~~ [anakrish,mingweishih] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment