openenclave / oeedger8r-cpp

An implementation of oeedger8r in C++
MIT License
8 stars 13 forks source link

CodeQL Analysis #73

Closed rs-- closed 3 years ago

rs-- commented 3 years ago

Utilizing the CodeQL security scan from the openenclave-security repository, the oeedger8r-cpp repository will be scanned on a nightly basis. The scan will be ran on the oeciteam/oetools-minimal-18.04:latest docker image, hosted on a GitHub-hosted Ubuntu box corresponding to the ubuntu-latest tag. Currently, this tag corresponds to 18.04, but will transition to 20.04 in the near future; this should be irrelevant as the actual scan in ran in a container as noted above.

Notes:

Please refer to the openenclave-security repository, or @mrragava for questions regarding the CodeQL scan.

oe-ci-robot commented 3 years ago

Welcome @rs--!

It looks like this is your first PR to openenclave/oeedger8r-cpp 🎉🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if openenclave/oeedger8r-cpp has its own contribution guidelines.

Thank you, and welcome to openenclave. :smiley:

oe-ci-robot commented 3 years ago

Hi @rs--. Thanks for your PR.

I'm waiting for a openenclave member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
anakrish commented 3 years ago

/lgtm

anakrish commented 3 years ago

/ok-to-test

anakrish commented 3 years ago

/approve

anakrish commented 3 years ago

/lgtm

oe-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anakrish, rs--

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openenclave/oeedger8r-cpp/blob/master/OWNERS)~~ [anakrish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment