search

openenclave / oeedger8r-cpp

An implementation of oeedger8r in C++
MIT License
8 stars 13 forks source link

Remote CodeQL Reference #74

Closed rs-- closed 3 years ago

rs-- commented 3 years ago

Updated CodeQL configuration:

oe-ci-robot commented 3 years ago

Hi @rs--. Thanks for your PR.

I'm waiting for a openenclave member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mingweishih commented 3 years ago

\lgtm

mrragava commented 3 years ago

/lgtm /approved

mrragava commented 3 years ago

/lgtm

mrragava commented 3 years ago

/approved

mingweishih commented 3 years ago

@rs-- Do you know why the tests are failing?

rs-- commented 3 years ago

@mingweishih the prow server seems to be restarting.

Checking job status at https://openenclave-jenkins.eastus.cloudapp.azure.com/queue/item/34013/api/json (#17/17)
Job is in queue because: Jenkins is about to shut down
oe-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anakrish, rs--

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openenclave/oeedger8r-cpp/blob/master/OWNERS)~~ [anakrish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oe-ci-robot commented 3 years ago

@rs--: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pr-oeedger8r-cpp-Rhel8BuildClang-8 fc51ed03dc1475609b78a188e4418290aa2fbd7f link /test pr-oeedger8r-cpp-Rhel8BuildClang-8
pr-oeedger8r-cpp-Ubuntu1804BuildClang-8 fc51ed03dc1475609b78a188e4418290aa2fbd7f link /test pr-oeedger8r-cpp-Ubuntu1804BuildClang-8
pr-oeedger8r-cpp-Ubuntu1604BuildClang-8 fc51ed03dc1475609b78a188e4418290aa2fbd7f link /test pr-oeedger8r-cpp-Ubuntu1604BuildClang-8
pr-oeedger8r-cpp-Windows2019Build fc51ed03dc1475609b78a188e4418290aa2fbd7f link /test pr-oeedger8r-cpp-Windows2019Build
pr-oeedger8r-cpp-Windows2016Build fc51ed03dc1475609b78a188e4418290aa2fbd7f link /test pr-oeedger8r-cpp-Windows2016Build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by opening an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).