search

openenergymonitor / EmonESP

ESP8266 WIFI serial to emoncms link
160 stars 78 forks source link

How to upload pre-compiled binaries readme update #67

Closed danbates2 closed 4 years ago

jeremypoulter commented 4 years ago

You shouldn't add the pre-compiled binaries. GitHub has a releases section for this

danbates2 commented 4 years ago

True. Noticed. I've updated my branch and amended the doco. This Okay?

glynhudson commented 4 years ago

Correct, the pre-compiled binaries are attached to each release on the github released page. I added a section to the readme in your PR to mention out emonupload tool which is the easiest way to load the latest pre-compiled FW. This is what we use in the factory.

I'm not keen on having the libraries committed in the repository, it's far better to just have the specific library version defined in platfromio. However, if users really want to use arduino the best way would be to use a git sub-module to pull in the libraries if required without making the repo bloated. You should create a new libraries path e.g /arduino-libs since the src/libraries folder is used by platfromio. If there lib files in src/libraries I think platfromio will automatically use them instead of downloading the correct libraries.

It's a good idea to define the espressive platfrom version. Out of interest was 1.8.0 choosen for any specific reason? We're currently having wifi stability isssues with the ESP at the moment which we're trying to debug so I'm keen to fix as many variables as possible to try and figure out what's causing the instability.

danbates2 commented 4 years ago

v1.8.0 uses core v2.4.2 which is the most recent stable core for emonesp-master.

I'll change it to src/arduino-libs to avoid any confusion... done.

Do you want to include the emonupload tool in the doco now or when we next do a release of emonesp?

glynhudson commented 4 years ago

Thanks, that's great.

There's no harm in mentioning emonupload now, it works fine for EmonESP, we've been using it since day 1 as a primary method of loading FW onto each EmonESP before they are shipped.