openenergymonitor / EmonScripts

Emoncms Stack Installation and Update scripts
16 stars 30 forks source link

Assumption of user pi breaks non Pi installs #153

Closed borpin closed 1 year ago

borpin commented 1 year ago

https://github.com/openenergymonitor/EmonScripts/blob/69e87221dacd5fba9b18ed320f9ba9aa5513946e/update/main.sh#L60

This breaks an install on any system other than an RPi.

It should use the user in the config.ini

https://github.com/openenergymonitor/EmonScripts/blob/69e87221dacd5fba9b18ed320f9ba9aa5513946e/update/main.sh#L23

Breaks an install running as root. It should honour the user set in the config.ini

bramco commented 1 year ago

Assume this is a hangover from the days before a new install of Raspbian asks users to set up a user name.

Until the script is fixed, a note on the instructions to say that users must use 'pi' as the user would save a lot of frustration.

borpin commented 1 year ago

Yes agreed, but the update script should still respect the install config file, no matter what.

borpin commented 1 year ago

110 is a duplicate