search

openenergymonitor / emonpi

Raspberry Pi Based Energy Monitor. Hardware, Firmware & related software for the PI.
https://guide.openenergymonitor.org/setup
270 stars 113 forks source link

Revise mariadb ProtectHome fix #104

Closed pb66 closed 5 years ago

pb66 commented 5 years ago

Removed "fix" from install script as not required. Changed update to write file rather than cp so that there is no need for a copy of the file in the repo (as not needed down the line). Removed repo copy of redundant file.

borpin commented 5 years ago

@pb66

Could you check for the location of the mysql database and only introduce the change if it is located in home? Or check and see if the newer /var/opt/emon/ location exists and not install the override if it does?

Just thinking that the update script is the same however the emoncms instance has been installed. Having installed via the script, I think this update would introduce an override that was not required.

pb66 commented 5 years ago

Discussed further back on the forum (https://community.openenergymonitor.org/t/warning-do-not-do-apt-get-dist-upgrade/10823/30?u=pb66) to try and keep it altogether.

glynhudson commented 5 years ago

Ah sure, this is a good suggestion

pb66 commented 5 years ago

@glynhudson can you please also merge PR https://github.com/openenergymonitor/emonpi/pull/105. This wasn't yet complete, I've improved the test to see if the path is set to /home/pi in the mysql conf