openenergysolutions / modbus-cpp

Modbus TCP master library in modern C++
https://aegis4ics.github.io/modbus-cpp/
Apache License 2.0
2 stars 0 forks source link

Simplify ChannelTcp #4

Open emgre opened 6 years ago

emgre commented 6 years ago

There are multiple issues to me in this class:

A first avenue would be to separate the funneling from the message build/parser submission. It would clarify the code (I hope...)

jadamcrain commented 6 years ago

Ok. I trust your judgement on how best to do this. I assume the notes are mostly for your own reference.

I can have a look at the implementation sometime this week and see if there's any suggestions I can make.