search

openengsb / openengsb-wrapped-com.atlassian.jira.rest.client

Wrapped JIRA REST client
1 stars 1 forks source link

Make it again "really" wrapped and update required dependencies #1

Closed irentu closed 9 years ago

irentu commented 9 years ago

Currently the aim of this repo is to provide a wrapped version of the JIRA REST client developed by the atlassian. The cause of the library conflict can be simply avoided by adding the required version of the respective dependency explicitly, so jersey-client as 1.18.2. Therefore the cloned source code has been removed again. The version "2.0.0-m32-w1" was also not reflecting the reality, since there is no version of atlassian JIRA REST client as 2.0.0-m32 except the local modified. The latest one is 2.0.0-m31, so the first wrapped one should be 2.0.0-m31-w1.

mipe commented 9 years ago

The idea of adding the original source was to not only add dependency upgrades to the rest-client but to also deal with API breaks in case the dependency upgrades cause some. But since this jersey upgrade does not cause an API break this solution could also do the job for the time being.

Did you test both conflicting connectors with the changed wrapped rest client?

irentu commented 9 years ago

Yes, I tested both conflicting connectors by using logi-asb and custom-cdl. No conflicts detected.

As long as it is avoidable to maintain an additional forked codebase (no API breaks etc. as you mentinoned), it seems much less cumbersome to have a pure wrapped repo.

mipe commented 9 years ago

ok I've released it as 2.0.0-m31.w1

should be available soon.

irentu commented 9 years ago

Great, thanks!