openep / openep-core

Core OpenEP code - Matlab implementation
Apache License 2.0
9 stars 6 forks source link

Add initial tests for importcarto_mem #54

Closed p-j-smith closed 2 years ago

p-j-smith commented 2 years ago
codecov[bot] commented 2 years ago

Codecov Report

Merging #54 (4115781) into develop (f50b5d5) will increase coverage by 9.22%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop      #54      +/-   ##
===========================================
+ Coverage     8.14%   17.37%   +9.22%     
===========================================
  Files          147      147              
  Lines         6862     6862              
===========================================
+ Hits           559     1192     +633     
+ Misses        6303     5670     -633     
Impacted Files Coverage Δ
private/strstartcmp.m 100.00% <0.00%> (+25.00%) :arrow_up:
private/strwordpositions.m 39.13% <0.00%> (+39.13%) :arrow_up:
private/findclosestvertex.m 88.57% <0.00%> (+42.85%) :arrow_up:
private/xml_readnode.m 54.10% <0.00%> (+54.10%) :arrow_up:
private/xml_read.m 59.13% <0.00%> (+59.13%) :arrow_up:
read_ecgfile_v4.m 62.96% <0.00%> (+62.96%) :arrow_up:
read_forcefile_v2.m 75.00% <0.00%> (+75.00%) :arrow_up:
getpointelectrogramname.m 75.86% <0.00%> (+75.86%) :arrow_up:
read_ecgfile_v4_header.m 77.46% <0.00%> (+77.46%) :arrow_up:
read_positions_on_annotation_v2.m 78.12% <0.00%> (+78.12%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f50b5d5...4115781. Read the comment docs.

p-j-smith commented 2 years ago

The tests run okay on github actions now (I was having some issues setting the correct path to the openep-testingdata directory after downloading it).

To run the tests locally within matlab, make sure the openep-examples and openep-testingdata are both in the path, and also set the path to openep-testingdata as an environment variable:

setenv("OPENEP_TESTING_DATA", "/path/to/openep-testingdata");

and then to run the tests:

results = runtests('/path/to/openep-core', 'IncludeSubfolders', true);