openep / openep-core

Core OpenEP code - Matlab implementation
Apache License 2.0
9 stars 6 forks source link

'repack' parameter of 'getMesh' renamed to 'limitToTriangulation' #59

Closed p-j-smith closed 2 years ago

p-j-smith commented 2 years ago

The repack argument of getMesh was renamed to limitToTriangulation. However, calls to getMesh were not updated to use the new argument name.

For example, in HoleCutter:

hc = HoleCutter(getMesh(userdata, 'type', 'triangulation', 'repack', true), hT);

The result is that the repack argument is ignored, and the mesh is not limited to points only referenced in the triangulation. This causes a segmentation fault when later calling the geodesic library.

p-j-smith commented 2 years ago

Closed by #60