Closed p-j-smith closed 2 years ago
Merging #63 (3a613ba) into develop (ea779f7) will increase coverage by
1.10%
. The diff coverage is56.14%
.
@@ Coverage Diff @@
## develop #63 +/- ##
==========================================
+ Coverage 7.03% 8.14% +1.10%
==========================================
Files 144 147 +3
Lines 6805 6862 +57
==========================================
+ Hits 479 559 +80
+ Misses 6326 6303 -23
Impacted Files | Coverage Δ | |
---|---|---|
editUserdata.m | 0.00% <0.00%> (ø) |
|
generateInterpData.m | 0.00% <0.00%> (ø) |
|
getAblationArea.m | 0.00% <0.00%> (ø) |
|
getAnatomicalStructures.m | 0.00% <0.00%> (ø) |
|
getArea.m | 0.00% <0.00%> (ø) |
|
getClosedSurface.m | 0.00% <0.00%> (ø) |
|
getConductionVelocity.m | 0.00% <0.00%> (ø) |
|
getEarliestActivationSite.m | 0.00% <0.00%> (ø) |
|
getFaces.m | 0.00% <0.00%> (ø) |
|
getLatestActivationSite.m | 0.00% <0.00%> (ø) |
|
... and 10 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 43d91a0...3a613ba. Read the comment docs.
@p-j-smith , I will approve this for merging now; but please can you add the changes to the changelog.md file (*which only exists in its own branch just now) (I have asked @nicklinton to approve the PR related to the changelog branch such that it can be propagated into the other feature branches too).
Changes made:
batchAnonymise.m
to anonymise userdata. The fields containing the path to the original data are removed as we cannot guarantee this do not contain potentially identifiable dataopenep_updateuserdata.m
to improve interoperability withopenep-py
. This convertsuserdata.surface.triRep
into astruct
, which can be read byopenep-py
(whereas atriRep
cannot be read)batchConvert.m
, which converts convertstriRep
tostruct
for all.mat
in a directoryopenep-py
than -v7.3, and the saved file is significantly smaller compared to -v6 files.getMesh
is used where necessary (rather than e.g.userdata.surface.triRep.X
)