openep / openep-core

Core OpenEP code - Matlab implementation
Apache License 2.0
9 stars 6 forks source link

Feature/octaray #85

Closed nicklinton closed 1 year ago

nicklinton commented 1 year ago

tests work on my local machine

nicklinton commented 1 year ago

This is the outcome from running importCartoMemTest (which fails to load on web) ...

Accessing: E:\carto\Carto\Export_Study-1-11_25_2021-15-01-32\Study 1 11_25_2021 15-01-32.xml .......... .......... ....... Done importCartoMemTest


ans =

1×27 TestResult array with properties:

Name
Passed
Failed
Incomplete
Duration
Details

Totals: 27 Passed, 0 Failed, 0 Incomplete. 53.3946 seconds testing time.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 82.23% and project coverage change: +1.79 :tada:

Comparison is base (afb339d) 19.23% compared to head (dc2ffc7) 21.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #85 +/- ## =========================================== + Coverage 19.23% 21.03% +1.79% =========================================== Files 147 147 Lines 6918 7136 +218 =========================================== + Hits 1331 1501 +170 - Misses 5587 5635 +48 ``` | [Impacted Files](https://codecov.io/gh/openep/openep-core/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openep) | Coverage Δ | | |---|---|---| | [batchConvert.m](https://codecov.io/gh/openep/openep-core/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openep#diff-YmF0Y2hDb252ZXJ0Lm0=) | `92.85% <ø> (ø)` | | | [comparestructure.m](https://codecov.io/gh/openep/openep-core/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openep#diff-Y29tcGFyZXN0cnVjdHVyZS5t) | `0.00% <0.00%> (ø)` | | | [private/xml\_read.m](https://codecov.io/gh/openep/openep-core/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openep#diff-cHJpdmF0ZS94bWxfcmVhZC5t) | `58.90% <ø> (-0.24%)` | :arrow_down: | | [private/xml\_readnode.m](https://codecov.io/gh/openep/openep-core/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openep#diff-cHJpdmF0ZS94bWxfcmVhZG5vZGUubQ==) | `53.69% <ø> (-0.42%)` | :arrow_down: | | [read\_electrodePositionsOnAnnotation.m](https://codecov.io/gh/openep/openep-core/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openep#diff-cmVhZF9lbGVjdHJvZGVQb3NpdGlvbnNPbkFubm90YXRpb24ubQ==) | `74.68% <74.68%> (ø)` | | | [read\_meshfile.m](https://codecov.io/gh/openep/openep-core/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openep#diff-cmVhZF9tZXNoZmlsZS5t) | `89.01% <87.87%> (-4.47%)` | :arrow_down: | | [read\_ecgfile\_v4.m](https://codecov.io/gh/openep/openep-core/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openep#diff-cmVhZF9lY2dmaWxlX3Y0Lm0=) | `86.53% <94.73%> (+23.57%)` | :arrow_up: | | [getCartoConnectorElectrodeNaming.m](https://codecov.io/gh/openep/openep-core/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openep#diff-Z2V0Q2FydG9Db25uZWN0b3JFbGVjdHJvZGVOYW1pbmcubQ==) | `100.00% <100.00%> (ø)` | | | [read\_positions\_on\_annotation\_v2.m](https://codecov.io/gh/openep/openep-core/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openep#diff-cmVhZF9wb3NpdGlvbnNfb25fYW5ub3RhdGlvbl92Mi5t) | `68.18% <100.00%> (-9.95%)` | :arrow_down: | | [read\_ecgfile\_v4\_header.m](https://codecov.io/gh/openep/openep-core/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openep#diff-cmVhZF9lY2dmaWxlX3Y0X2hlYWRlci5t) | `0.00% <0.00%> (-77.47%)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/openep/openep-core/pull/85?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openep) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openep). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openep)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nicklinton commented 1 year ago

please can we complete the pull request following the testing in Madrid?