search

openepcis / epcis-testdata-generator

EPCIS 2.0 Testdata Generator
https://openepcis.io
Apache License 2.0
3 stars 2 forks source link

recordTime value too long #34

Closed RalphTro closed 1 year ago

RalphTro commented 1 year ago

Dear @Aravinda93 , When generating test data via https://test-data-generator.openepcis.io/ui/GenerateEvents, the recordTime value currently has a length which doesn't validate against the JSON schema anymore, e.g. " recordTime": "2023-08-10T13:22:09.078499373Z", (BTW: The design template does not require/specify this level of precision.) Now, if I paste the generated events into https://www.jsonschemavalidator.net/ and test it against the EPCIS JSON schema, it only validates if I remove at least 2 digits in the ms string. Please asjust (I think in most cases, a 1-2 digit ms precision, if at all, is absolutely sufficient anyway.) Kind regards, Ralph

Aravinda93 commented 1 year ago

Dear @RalphTro

Thanks a lot for bringing this to the notice, I am on it. I will check and fix it right away.

sboeckelmann commented 1 year ago

@Aravinda93 This may already have been resolved in current model code-base

Aravinda93 commented 1 year ago

@sboeckelmann Thanks a lot for reminding :) Yes, this has been fixed and I am unable to reproduce it locally.

@RalphTro This issue will be fixed in production during the next deployment, along with other issues.

Best regards, Aravinda

RalphTro commented 1 year ago

Many thanks, @Aravinda93 and @sboeckelmann!