search

openepcis / openepcis-document-converter

Convert GS1 EPCIS events from JSON-LD to XML format and vice versa.
https://openepcis.io
Apache License 2.0
3 stars 1 forks source link

Using the Context Holder approach for Namespaces instead of ThreadLocal #9

Closed Aravinda93 closed 1 year ago

Aravinda93 commented 1 year ago

Based on the changes to openepcis-models where the namespaces storing approach was enhanced using the context holder approach instead of the ThreadLocal approach. This required the changes in document converter tool. This PR will contain the changes based on it.

Kindly request you to review the changes and approve the PR.

Aravinda93 commented 1 year ago

@sboeckelmann

Thanks a lot for the review. I have made the necessary modifications based on your feedback.

After researching and reviewing the changes, I believe the code is now thread safe. Could you please review the changes and confirm again? If there are any further modifications required to ensure the code is thread safe and can run into any issues during parallel execution, please let me know and I will make the necessary changes.

Kindly request you to review the changes and approve the PR.