search

openepcis / openepcis-epc-digitallink-translator

EPC to GS1 Digital Link Toolset Library
https://openepcis.io
Apache License 2.0
2 stars 2 forks source link

Refactoring and optimisation based on the review provided. #2

Closed Aravinda93 closed 1 year ago

Aravinda93 commented 1 year ago

The whole project has been refactored and made modification for better performance and enhancement. Kindly request you to review the changes and approve the merge request.

Aravinda93 commented 1 year ago

@sboeckelmann

I have removed the 0 adding logic from GCP length finding, instead of that added the logic to check if the identifier is not part of keyStartsWithGCP and if the identifier has more than 13 digits then considering the identifier from 2nd digit else considering the complete identifier. With this approach the GIAI identifier is working as expected.

Kindly request you to review the code once and merge to main branch.

Thanks and best regards, Aravinda